Re: [PATCH 0/5] selftests/sgx: Fix compilation errors.

From: Jarkko Sakkinen
Date: Fri Jul 28 2023 - 15:02:10 EST


On Mon Jul 24, 2023 at 4:58 PM UTC, Jo Van Bulck wrote:
> Hi,
>
> This patch series ensures that all SGX selftests succeed when compiling
> with optimizations (as tested with -O{0,1,2,3,s} for both gcc 11.3.0 and
> clang 14.0.0). The aim of the patches is to avoid reliance on undefined,
> compiler-specific behavior that can make the test results fragile.
>
> If deemed useful, I can also include an elementary wrapper shell script to
> compile and run the tests for different compilers (gcc/clang) and
> optimization levels.

Thank you, this sounds like an appropriate scope for the selftest.

I support also the idea of refining the selftest as a run-time, which
could perhaps consist of the following steps:

1. Create a repository of the self-compiling selftest with GPLv2. You
could add also AUTHORS file for the initial content by crawling this
data from the git log.
2. Create a commit with sob's from the required stakeholders, which
changes the license to something more appropriate, and get the
sob's with some process.

BR, Jarkko