Re: [PATCH v2] selinux: move debug functions into debug configuration

From: Paul Moore
Date: Fri Jul 28 2023 - 14:09:40 EST


On Jul 28, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@xxxxxxxxxxxxxx> wrote:
>
> avtab_hash_eval() and hashtab_stat() are only used in policydb.c when
> the configuration SECURITY_SELINUX_DEBUG is enabled.
>
> Move the function definitions under that configuration as well and
> provide empty definitions in case SECURITY_SELINUX_DEBUG is disabled, to
> avoid using #ifdef in the callers.
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> ---
> v2:
> - provide empty definitions for !SECURITY_SELINUX_DEBUG
> - drop #ifdef in caller
> ---
> security/selinux/ss/avtab.c | 2 ++
> security/selinux/ss/avtab.h | 7 +++++++
> security/selinux/ss/hashtab.c | 3 ++-
> security/selinux/ss/hashtab.h | 6 ++++++
> security/selinux/ss/policydb.c | 5 +++--
> 5 files changed, 20 insertions(+), 3 deletions(-)

Merged into selinux/next, thanks!

--
paul-moore.com