Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis

From: Alexon Oliveira
Date: Fri Jul 28 2023 - 13:43:23 EST


On Fri, Jul 28, 2023 at 08:24:56AM +0300, Dan Carpenter wrote:
> On Thu, Jul 27, 2023 at 02:37:54PM -0300, Alexon Oliveira wrote:
> > >
> > > I would have thought you would get a "line is too long" warning, that
> > > didn't happen?
> > $ pwd
> > /home/alolivei/git/kernels/staging
> > $ perl scripts/checkpatch.pl --strict -f drivers/staging/vme_user/vme_bridge.h | grep -i parenthesis
> > $
> > Nope. I didn't get any of that. Check it out:
>
> Heh. The warning is there but you used grep to remove it.
>

I only used grep so as not to pollute my answer with too long
output, but you can validate the full output by running the following:

curl -ks https://people.redhat.com/alolivei/kernel/evidence

You'll see there's no warning related to this patch.
As I mentioned, there are other warnings that were already there before
I submitted the patch, and I didn't touch them (yet).

> Speaking of long lines. Could you fix your email client to line wrap at
> 75 characters.
>

ACK. Done.

> regards,
> dan carpenter
>

Thank you.

Alexon Oliveira