Re: [PATCH 3/3] kunit: Allow kunit test modules to use test filtering
From: kernel test robot
Date: Fri Jul 28 2023 - 13:26:00 EST
Hi Janusz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shuah-kselftest/kunit-fixes]
[also build test WARNING on linus/master v6.5-rc3]
[cannot apply to shuah-kselftest/kunit next-20230728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Janusz-Krzysztofik/kunit-Report-the-count-of-test-suites-in-a-module/20230728-234736
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes
patch link: https://lore.kernel.org/r/20230728154419.1810177-8-janusz.krzysztofik%40linux.intel.com
patch subject: [PATCH 3/3] kunit: Allow kunit test modules to use test filtering
config: hexagon-randconfig-r045-20230728 (https://download.01.org/0day-ci/archive/20230729/202307290124.BnnhRy8b-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290124.BnnhRy8b-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307290124.BnnhRy8b-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> lib/kunit/executor.c:182:42: warning: declaration of 'struct suite_set' will not be visible outside of this function [-Wvisibility]
182 | static void kunit_exec_list_tests(struct suite_set *suite_set)
| ^
lib/kunit/executor.c:190:25: error: incomplete definition of type 'struct suite_set'
190 | for (suites = suite_set->start; suites < suite_set->end; suites++)
| ~~~~~~~~~^
lib/kunit/executor.c:182:42: note: forward declaration of 'struct suite_set'
182 | static void kunit_exec_list_tests(struct suite_set *suite_set)
| ^
lib/kunit/executor.c:190:52: error: incomplete definition of type 'struct suite_set'
190 | for (suites = suite_set->start; suites < suite_set->end; suites++)
| ~~~~~~~~~^
lib/kunit/executor.c:182:42: note: forward declaration of 'struct suite_set'
182 | static void kunit_exec_list_tests(struct suite_set *suite_set)
| ^
lib/kunit/executor.c:198:19: error: variable has incomplete type 'struct suite_set'
198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end};
| ^
lib/kunit/executor.c:198:9: note: forward declaration of 'struct suite_set'
198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end};
| ^
In file included from lib/kunit/executor.c:230:
lib/kunit/executor_test.c:45:19: error: variable has incomplete type 'struct suite_set'
45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:45:9: note: forward declaration of 'struct suite_set'
45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:46:19: error: variable has incomplete type 'struct suite_set'
46 | struct suite_set got;
| ^
lib/kunit/executor_test.c:45:9: note: forward declaration of 'struct suite_set'
45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:69:19: error: variable has incomplete type 'struct suite_set'
69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:69:9: note: forward declaration of 'struct suite_set'
69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:70:19: error: variable has incomplete type 'struct suite_set'
70 | struct suite_set got;
| ^
lib/kunit/executor_test.c:69:9: note: forward declaration of 'struct suite_set'
69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:96:19: error: variable has incomplete type 'struct suite_set'
96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:96:9: note: forward declaration of 'struct suite_set'
96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:97:19: error: variable has incomplete type 'struct suite_set'
97 | struct suite_set got;
| ^
lib/kunit/executor_test.c:96:9: note: forward declaration of 'struct suite_set'
96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]};
| ^
lib/kunit/executor_test.c:138:4: warning: cast from 'void (*)(const void *)' to 'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function type [-Wcast-function-type-strict]
138 | (kunit_action_t *)kfree,
| ^~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 9 errors generated.
vim +182 lib/kunit/executor.c
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 181
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 @182 static void kunit_exec_list_tests(struct suite_set *suite_set)
aac35468ca20a3 Alan Maguire 2020-08-04 183 {
e5857d396f35e5 Daniel Latypov 2022-07-09 184 struct kunit_suite * const *suites;
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 185 struct kunit_case *test_case;
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 186
6c738b52316c58 Rae Moar 2022-11-23 187 /* Hack: print a ktap header so kunit.py can find the start of KUnit output. */
6c738b52316c58 Rae Moar 2022-11-23 188 pr_info("KTAP version 1\n");
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 189
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 190 for (suites = suite_set->start; suites < suite_set->end; suites++)
e5857d396f35e5 Daniel Latypov 2022-07-09 191 kunit_suite_for_each_test_case((*suites), test_case) {
e5857d396f35e5 Daniel Latypov 2022-07-09 192 pr_info("%s.%s\n", (*suites)->name, test_case->name);
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 193 }
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 194 }
9c6b0e1d8993e4 Daniel Latypov 2021-09-30 195
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki