Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

From: Krzysztof Kozlowski
Date: Fri Jul 28 2023 - 07:48:10 EST


On 28/07/2023 12:28, Varshini Rajendran wrote:
> Document sam9x7 compatible for usb ohci.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index be268e23ca79..a2490759f694 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -57,6 +57,12 @@ properties:
> - nxp,ohci-nxp
> - st,spear600-ohci
> - const: usb-ohci
> + - items:
> + - enum:
> + - microchip,sam9x7-ohci
> + - enum:

That's not an enum. You cannot have here different compatibles.

> + - atmel,at91rm9200-ohci
> + - const: usb-ohci
>
> reg:
> maxItems: 1

Best regards,
Krzysztof