Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support

From: Arnd Bergmann
Date: Fri Jul 28 2023 - 06:47:05 EST


On Fri, Jul 28, 2023, at 09:49, Yinbo Zhu wrote:
> The Loongson-2's power management controller was ACPI, supports ACPI
> S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
> Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods
> (USB, GMAC, PWRBTN, etc.). This driver was to add power management
> controller support that base on dts for Loongson-2 series SoCs.
>
> Co-developed-by: Liu Yun <liuyun@xxxxxxxxxxx>
> Signed-off-by: Liu Yun <liuyun@xxxxxxxxxxx>
> Co-developed-by: Liu Peibao <liupeibao@xxxxxxxxxxx>
> Signed-off-by: Liu Peibao <liupeibao@xxxxxxxxxxx>
> Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>

Adding Ulf Hansson to Cc

Ulf has recently split out the "genpd" framework and split out
drivers/genpd from drivers/soc since I'm generally not that involved
in the pwoer management side.

Can you have a look at whether this driver should also be part
of drivers/genpd rather than drivers/soc, and/or converted
to use the genpd infrastructure?

Thanks,

Arnd