Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys

From: Petr Machata
Date: Fri Jul 28 2023 - 06:00:25 EST



Ratheesh Kannoth <rkannoth@xxxxxxxxxxx> writes:

> As 32bit of dissector->used_keys are exhausted,
> increase the size to 64bits.
>
> This is base changes for ESP/AH flow dissector patch.
> Please find patch and discussions at
> https://lore.kernel.org/netdev/ZMDNjD46BvZ5zp5I@xxxxxxxxxxxx/T/#t
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> Reviewed-by: Petr Machata <petrm@xxxxxxxxxx>

This makes it look like I reviewed the whole thing. I think I wrote
this:

Reviewed-by: Petr Machata <petrm@xxxxxxxxxx> # for mlxsw

Also, you either missed or ignored my proposal for subject line update.
I do think that "net: flow_dissector:" would be a better prefix, because
that's how the component is called, and it's in the net namespace. It's
OK not to agree, but in that case please argue to that end.