Re: [PATCH v5 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI

From: William Qiu
Date: Fri Jul 28 2023 - 05:03:10 EST




On 2023/7/28 16:58, Conor Dooley wrote:
> Hey William,
>
> Since you pinged things, I had a quick look.
>
> On Wed, Jul 19, 2023 at 05:25:44PM +0800, William Qiu wrote:
>> Add JH7110's clock initialization code to the driver.
>>
>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
>
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@xxxxxxxxx/
>> Reported-by: Julia Lawall <julia.lawall@xxxxxxxx>
>> Closes: https://lore.kernel.org/r/202306040644.6ZHs55x4-lkp@xxxxxxxxx/
>
> These, as pointed out on the last version, should not be here.
> kernel test robot complaints about un-applied patches do not get a
> reported-by etc in subsequent versions of the same patchset, just as
> comments from human reviewers do not require reported-by tags.
>
> These tags should only be used when the code has been merged & you need
> to create a new patch to fix the issue.
>
> Hopefully, if the code is otherwise fine, Mark can fix this when he
> applies the patches.
>
> Thanks,
> Conor.

Hi Conor,

Fine, I will drop it in next version.

Best regards,
William