RE: [PATCH v3 1/2] ASoC: Intel: maxim-common: get codec number from ACPI

[Lu, Brent]

> >  static int max_98390_hw_params(struct snd_pcm_substream *substream,
> >  			       struct snd_pcm_hw_params *params)  {
> >  	struct snd_soc_pcm_runtime *rtd =
> asoc_substream_to_rtd(substream);
> >  	struct snd_soc_dai *codec_dai;
> > +	int i, ret = 0;
> 
> Redundant assignment.
> 
Will fix it in v4 patch.

> 
> Maybe (maybe, don't know subsystem preferences)
> 
> #define MAX_98390_DEV0_NAME	"i2c-" MAX_98390_ACPI_HID ":00"
> #define MAX_98390_DEV1_NAME	"i2c-" MAX_98390_ACPI_HID ":01"
> #define MAX_98390_DEV2_NAME	"i2c-" MAX_98390_ACPI_HID ":02"
> #define MAX_98390_DEV3_NAME	"i2c-" MAX_98390_ACPI_HID ":03"
> 

Will include this change in v4 patch. Thanks for reviewing.

Regards,
Brent