Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro

From: Sohil Mehta
Date: Thu Jul 27 2023 - 18:05:39 EST


On 7/27/2023 2:21 PM, Randy Dunlap wrote:
> On 7/27/23 13:06, Sohil Mehta wrote:
>> I am not sure if a Fixes tag is really needed for a redundant macro
>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>
> I don't see any need for this patch to be backported.
>
> Should it be commit 874bcd00f520c? Maybe. That one certainly
> missed moving this macro.
>

Also, applying this patch anytime before 874bcd00f520c will cause a
compilation issue unless 874bcd00f520c is applied as well.

-Sohil