Re: [PATCH 1/2] tty: vt: Fix spelling typo in comment

From: Samuel Thibault
Date: Thu Jul 27 2023 - 16:46:07 EST


oushixiong, le mer. 26 juil. 2023 17:10:43 +0800, a ecrit:
> Signed-off-by: oushixiong <oushixiong@xxxxxxxxxx>
> ---
> drivers/tty/vt/vt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 1e8e57b45688..bcdd249e47a0 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -3473,7 +3473,7 @@ static int __init con_init(void)
> INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
> tty_port_init(&vc->port);
> visual_init(vc, currcons, 1);
> - /* Assuming vc->vc_{cols,rows,screenbuf_size} are sane here. */
> + /* Assuming vc->vc_{cols,rows,screenbuf_size} are same here. */

? No, this is really meant to be "sane" here, i.e. they are not getting
checked, and just used as they are.

> vc->vc_screenbuf = kzalloc(vc->vc_screenbuf_size, GFP_NOWAIT);
> vc_init(vc, vc->vc_rows, vc->vc_cols,
> currcons || !vc->vc_sw->con_save_screen);