Re: [PATCH] fuse: enable larger read buffers for readdir.

From: Bernd Schubert
Date: Thu Jul 27 2023 - 15:43:09 EST




On 7/27/23 21:21, Miklos Szeredi wrote:
On Wed, 26 Jul 2023 at 20:40, Jaco Kroon <jaco@xxxxxxxxx> wrote:

Will look into FUSE_INIT. The FUSE_INIT as I understand from what I've
read has some expansion constraints or the structure is somehow
negotiated. Older clients in other words that's not aware of the option
will follow some default. For backwards compatibility that default
should probably be 1 page. For performance reasons it makes sense that
this limit be larger.

Yes, might need this for backward compatibility. But perhaps a
feature flag is enough and the readdir buf can be limited to
fc->max_read.

fc->max_read is set by default to ~0 and only set to something else when the max_read mount option is given? So typically that is a large value (UINT_MAX)?


Thanks,
Bernd