Re: [PATCH v2 1/2] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver

From: Devarsh Thakkar
Date: Thu Jul 27 2023 - 08:28:39 EST


Hi Krzysztof,

Thanks for the quick review.

On 27/07/23 17:33, Krzysztof Kozlowski wrote:
> On 27/07/2023 13:25, Devarsh Thakkar wrote:
>> Add dt-bindings for Imagination E5010 JPEG Encoder driver which is
>> implemented as stateful V4L2 M2M driver.
>>
>> Co-developed-by: David Huang <d-huang@xxxxxx>
>> Signed-off-by: David Huang <d-huang@xxxxxx>
>> Signed-off-by: Devarsh Thakkar <devarsht@xxxxxx>
>> ---
>> V2: No change, just sending this together with driver and cover-letter
>
> So all other comments get ignored? Yeah, I see.
>

Sorry my bad, I somehow missed to notice you had replied already due to some
bad filtering of emails. I will check your comments and get back.

Regards
Devarsh

> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof
>