Re: [PATCH] arm64/mm: Set only the PTE_DIRTY bit while preserving the HW dirty state

From: Will Deacon
Date: Thu Jul 27 2023 - 08:23:32 EST


On Thu, 13 Jul 2023 12:45:18 +0530, Anshuman Khandual wrote:
> pte_mkdirty() creates dirty states both in SW and HW bits, which is really
> not required, either in pte_wrprotect() or pte_modify() for preserving the
> HW dirty state. Because pte_mkdirty() sets PTE_DIRTY and clears PTE_RDONLY
> as pte_write() always evaluates to be true - otherwise pte_hw_dirty() will
> not test out in the first place. Clearing PTE_RDONLY again is not required
> here because the pte is already in pte_hw_dirty() but might soon loose its
> dirty state thus requiring preservation in SW dirty bit i.e PTE_DIRTY.
>
> [...]

Applied to arm64 (for-next/mm), thanks!

[1/1] arm64/mm: Set only the PTE_DIRTY bit while preserving the HW dirty state
https://git.kernel.org/arm64/c/6477c3886ae1

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev