Re: [PATCH] sched/fair: remove util_est boosting

From: Qais Yousef
Date: Thu Jul 27 2023 - 07:56:40 EST


On 07/24/23 23:11, Dietmar Eggemann wrote:

> Reran the Jankbench test with the patch (fix) on exactly the same
> platform (Pixel6, Android 12) I used for v3 (base, runnable):
>
> https://lkml.kernel.org/r/20230515115735.296329-1-dietmar.eggemann@xxxxxxx
>
> Max_frame_duration:
> +-----------------+------------+
> | kernel | value [ms] |
> +-----------------+------------+
> | base | 163.1 |
> | runnable | 162.0 |
> | fix | 157.1 |
> +-----------------+------------+
>
> Mean_frame_duration:
> +-----------------+------------+----------+
> | kernel | value [ms] | diff [%] |
> +-----------------+------------+----------+
> | base | 18.0 | 0.0 |
> | runnable | 12.7 | -29.43 |
> | fix | 13.0 | -27.78 |
> +-----------------+------------+----------+
>
> Jank percentage (Jank deadline 16ms):
> +-----------------+------------+----------+
> | kernel | value [%] | diff [%] |
> +-----------------+------------+----------+
> | base | 3.6 | 0.0 |
> | runnable | 1.0 | -68.86 |
> | fix | 1.0 | -68.86 |
> +-----------------+------------+----------+
>
> Power usage [mW] (total - all CPUs):
> +-----------------+------------+----------+
> | kernel | value [mW] | diff [%] |
> +-----------------+------------+----------+
> | base | 129.5 | 0.0 |
> | runnable | 134.3 | 3.71 |
> | fix | 129.9 | 0.31 |
> +-----------------+------------+----------+
>
> Test results look good to me.
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Tested-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>

Thanks for re-running the test!


Cheers

--
Qais Yousef