Re: [PATCH 1/2] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family

[Krzysztof Kozlowski]

On 27/07/2023 12:18, Krzysztof Kozlowski wrote:
> On 27/07/2023 12:13, Marcus Folkesson wrote:
>> Microchip does have many similar chips, add those to the compatible
>> string as the driver support is extended.
>>
>> The new supported chips are:
>>   - microchip,mcp3910
>>   - microchip,mcp3912
>>   - microchip,mcp3913
>>   - microchip,mcp3914
>>   - microchip,mcp3918
>>   - microchip,mcp3919
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
>> ---
>>  .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml      | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> index f7b3fde4115a..06951ec5f5da 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> @@ -18,7 +18,13 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - microchip,mcp3910
>>        - microchip,mcp3911
>> +      - microchip,mcp3912
>> +      - microchip,mcp3913
>> +      - microchip,mcp3914
>> +      - microchip,mcp3918
>> +      - microchip,mcp3919
> 
> Your driver suggests that they are all compatible, so maybe just use one
> as fallback?

Oh, wait, you did put match data, just not in OF, but SPI. It's fine then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof