Re: [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK

From: Andi Shyti
Date: Thu Jul 27 2023 - 04:59:41 EST


Hi Carlos,

On Thu, Jul 27, 2023 at 11:03:47AM +0800, carlos.song@xxxxxxx wrote:
> From: Carlos Song <carlos.song@xxxxxxx>
>
> A NACK flag in ISR means i2c bus error. In such condition,
> there is no need to do read/write operation.
>
> In this patch, i2c will check MSR_NDF, MSR_RDF and MSR_TDF
> flag in turn, it's making mutually exclusive NACK/read/write.
> So when a NACK is received(MSR_NDF), i2c will return ISR
> directly and then stop i2c transfer.
>
> Signed-off-by: Carlos Song <carlos.song@xxxxxxx>

thanks!

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi