Re: [PATCH] crypto: all - alloc and init all req alloc as zero

From: Herbert Xu
Date: Thu Jul 27 2023 - 04:14:49 EST


On Thu, Jul 27, 2023 at 04:05:48PM +0800, Zhang Yiqun wrote:
> This patch is to change all req struct alloc function from kmalloc
> to kzalloc. Sometimes, it will incur some errors without initialized
> zero.
>
> Signed-off-by: Zhang Yiqun <zhangyiqun@xxxxxxxxxxxxxx>
> ---
> include/crypto/akcipher.h | 2 +-
> include/crypto/hash.h | 2 +-
> include/crypto/kpp.h | 2 +-
> include/crypto/skcipher.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)

Nack. Unless you have a specific issue please don't submit vague
patches like this. You should always state what issue led you to
make a change like this.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt