Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats

From: Anwar, Md Danish
Date: Thu Jul 27 2023 - 00:52:58 EST


On 7/26/2023 9:09 PM, Jakub Kicinski wrote:
On Wed, 26 Jul 2023 16:06:06 +0530 Md Danish Anwar wrote:
Are the bucket sizes configurable? Can we set the bucket sizes
to standard RMON ones and use ethtool RMON stats?

The bucket sizes are not configurable. Bucket size is read from hardware and is
fixed. I don't think we can configure bucket size and use ethtool RMON stats.
It's better to dump bucket sizes via ethtool -S.

The buckets in the ethtool API are up to the device to define.
Driver returns bucket ranges via struct ethtool_rmon_hist_range
from struct ethtool_ops::get_rmon_stats.

Sure Jakub I will try to implement this using ethtool_ops::get_rmon_stats.

--
Thanks and Regards,
Md Danish Anwar