Re: [PATCH v4 07/13] iommu/arm-smmu-v3: Keep track of attached ssids

From: Nicolin Chen
Date: Thu Jul 27 2023 - 00:45:24 EST


On Fri, Jul 21, 2023 at 02:48:23PM +0800, Michael Shavit wrote:
>
> > And since we have a group of subdomains that are simply indexed
> > by ssids, perhaps we can add an xarray to store a subdomain ptr
> > along with an ssid, replacing the list?
>
> Hmmmm, I think the only place where we search through the list for a
> specific SSID is during remove_dev_pasid. We mostly use the list to
> iterate over all the masters/ssids that this domain is attached to.
> I'm not sure if moving to an xarray to optimize the remove_dev_pasid
> call is worth it (at the cost of iterations which IIUC would become N
> log(N))

OK. That's fine.

Can we have a smaller rework series first? Let's have all data
structures defined. And then we can add features on top of it.

Thanks
Nicolin