Re: [PATCH v2] security: Fix ret values doc for security_inode_init_security()

From: Paul Moore
Date: Wed Jul 26 2023 - 17:08:20 EST


On Jul 26, 2023 Roberto Sassu <roberto.sassu@xxxxxxxxxxxxxxx> wrote:
>
> Commit 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for
> inode_init_security hook") unified the !initxattrs and initxattrs cases. By
> doing that, security_inode_init_security() cannot return -EOPNOTSUPP
> anymore, as it is always replaced with zero at the end of the function.
>
> Also, mentioning -ENOMEM as the only possible error is not correct. For
> example, evm_inode_init_security() could return -ENOKEY.
>
> Fix these issues in the documentation of security_inode_init_security().
>
> Fixes: 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for inode_init_security hook")
> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
> ---
> security/security.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Merged into lsm/next, thanks!

--
paul-moore.com