Re: [PATCH][next] net: ethernet: slicoss: remove redundant increment of pointer data

[Lino Sanfilippo]

Hi,

On 26.07.23 18:45, Colin Ian King wrote:
> The pointer data is being incremented but this change to the pointer
> is not used afterwards. The increment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index a30d0f172986..78231c85234d 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -1520,10 +1520,8 @@ static void slic_get_ethtool_stats(struct net_device *dev,
>
>  static void slic_get_strings(struct net_device *dev, u32 stringset, u8 *data)
>  {
> -	if (stringset == ETH_SS_STATS) {
> +	if (stringset == ETH_SS_STATS)
>  		memcpy(data, slic_stats_strings, sizeof(slic_stats_strings));
> -		data += sizeof(slic_stats_strings);
> -	}
>  }
>
>  static void slic_get_drvinfo(struct net_device *dev,

FWIW
Acked-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>

Best Regards,
Lino