Re: [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022

[Guenter Roeck]

On 7/26/23 11:27, Krzysztof Kozlowski wrote:
> On 26/07/2023 20:19, Guenter Roeck wrote:
> > > > +    enum: [1, 2, 4, 8]
> > > > +
> > > > +  average:
> > > > +    description: |
> > > > +      Number of samples to be used to report voltage, current and power values.
> > > > +      defaults to <0> when not set
> > > > +    enum: [0, 1, 2, 4, 8, 16, 32, 64, 128]
> > >
> > > I am sure hwmon has some property for this. Are you sure it is called
> > > "average"?
> >
> > Something with samples. adi,power-sample-average is similar. Others
> > use average-samples, qcom,avg-samples, touchscreen-average-samples.
>
> So probably it's a time to come with something generic, e.g.:
> average-samples in some hwmon.yaml

Maybe, but that is going to take a lot of time. Many configuration options
of hardware monitoring chips (such as the thermal sensor type, the ideality
factor of a thermal diode, or the number of pulses per revolution reported
by fans) are actually properties of the connected device, and Rob has made
clear that he expects such properties to be associated with the actual
device (fan, thermal sensor, etc). I don't even know how to model that,
and I really don't have the time (nor, really, the expertise) to come up
with acceptable generic bindings.

Guenter