Re: [RFC PATCH 3/4] dt-bindings: power: reset: Document arm,psci-vendor-reset

[Elliot Berman]

On 7/26/2023 6:45 AM, Rob Herring wrote:
> On Tue, Jul 25, 2023 at 12:01 PM Elliot Berman <quic_eberman@xxxxxxxxxxx> wrote:
> > On 7/24/2023 4:23 PM, Rob Herring wrote:
> > > On Mon, Jul 24, 2023 at 03:30:53PM -0700, Elliot Berman wrote:
> > > > Add devicetree bindings for using PSCI SYSTEM_RESET2 with vendor reset  types.
> > > >
> > > > Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>
> > > > ---
> > > >    .../power/reset/arm,psci-vendor-reset.yaml    | 35 +++++++++++++++++++
> > > >    MAINTAINERS                                   |  1 +
> > > >    2 files changed, 36 insertions(+)
> > > >    create mode 100644 Documentation/devicetree/bindings/power/reset/arm,psci-vendor-reset.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/power/reset/arm,psci-vendor-reset.yaml b/Documentation/devicetree/bindings/power/reset/arm,psci-vendor-reset.yaml
> > > > new file mode 100644
> > > > index 000000000000..18b0b8c167a1
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/power/reset/arm,psci-vendor-reset.yaml
> > > > @@ -0,0 +1,35 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > > +# Copyright 2023 Qualcomm Innovation Center, Inc. All Rights Reserved.
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/power/reset/arm,psci-vendor-reset.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: PSCI SYSTEM_RESET2 Vendor Resets
> > > > +
> > > > +maintainers:
> > > > +  - Elliot Berman <quic_eberman@xxxxxxxxxxx>
> > > > +
> > > > +description: |
> > > > +  PSCI SYSTEM_RESET2 supports vendor-defined reset types. This describes
> > > > +  the conversion of reboot modes to the reset types.
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: arm,psci-vendor-reset
> > > > +
> > > > +allOf:
> > > > +  - $ref: reboot-mode.yaml#
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +examples:
> > > > +  - |
> > > > +    firmware {
> > > > +      psci-vendor-resets {
> > > > +        compatible = "arm,psci-vendor-reset";
> > >
> > > We already have a node for PSCI, we don't need a second one. You can
> > > have a separate driver without a separate node.
> >
> > I could also place the reboot-mode functionality straight into
> > drivers/firwmare/psci/? I thought that might be more controversial than
> > separate driver, but maybe not?
> >
> > Mark/Loreno, do you have any concerns to add the reboot-mode driver
> > functionality directly in drivers/firmware/psci/psci.c?
>
> I'm talking about the binding. Why are you talking about driver
> design? They are independent.

Apologies, I agree to make it part of the same node. I believe it 
requires some changes to PSCI driver to create/bind the vendor restart 
device. I wanted to see how Mark and Lorenzo wanted to incorporate the 
vendor resets into PSCI driver: maybe I don't even create a 
device/driver and simply incorporate the changes into PSCI driver directly.