Re: [PATCH v2] spi: Use dev_err_probe instead of dev_err

From: Florian Fainelli
Date: Wed Jul 26 2023 - 11:02:21 EST




On 7/26/2023 3:54 AM, Wang Ming wrote:
It is possible that dma_request_chan will return EPROBE_DEFER,
which means that dev is not ready yet. In this case,
dev_err(dev), there will be no output. This patch fixes the bug.

Signed-off-by: Wang Ming <machel@xxxxxxxx>

This looks reasonable, though could you use the same prefix that was used for previous changes:

spi: bcm2835: Use dev_err_probe instead of dev_err

with that done, please add a:

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature