Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
From: Bart Van Assche
Date: Wed Jul 26 2023 - 10:54:32 EST
- Next message: Arnd Bergmann: "[PATCH] iomem: remove __weak ioremap_cache helper"
- Previous message: Zhangjin Wu: "[PATCH v2 3/7] selftests/nolibc: add extra configs customize support"
- In reply to: Daniel Wagner: "[PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Next in thread: Daniel Wagner: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 7/26/23 05:46, Daniel Wagner wrote:
Group all variable declarations together at the beginning of the
function.
An explanation of why this change has been proposed is missing from the
patch description.
I think the current style, with variable declarations occurring just
before the first use of a variable, is on purpose. I like that style.
Bart.
- Next message: Arnd Bergmann: "[PATCH] iomem: remove __weak ioremap_cache helper"
- Previous message: Zhangjin Wu: "[PATCH v2 3/7] selftests/nolibc: add extra configs customize support"
- In reply to: Daniel Wagner: "[PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Next in thread: Daniel Wagner: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]