Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver
From: Bryan O'Donoghue
Date: Wed Jul 26 2023 - 06:58:27 EST
On 19/06/2023 12:28, Jack Zhu wrote:
Add basic platform driver for StarFive Camera Subsystem.
Another nit here.
"Add basic driver" isn't a great title. Recommend "Add core driver".
Basic implies a thing that will be added to or improved upon but, this
code here is your "core" interface where you do your probing and
resource parsing/allocation etc.
Use "core" not "basic" to describe this.
---
bod