Re: [PATCH v7 5/6] media: starfive: camss: Add ISP driver

[Jack Zhu]

Hi Hans,

Thank you for your comment.

On 2023/7/26 17:11, Hans Verkuil wrote:
> Hi Jack,
> 
> On 19/06/2023 13:28, Jack Zhu wrote:
>> Add ISP driver for StarFive Camera Subsystem.
>> 
>> Signed-off-by: Jack Zhu <jack.zhu@xxxxxxxxxxxxxxxx>
>> ---
>>  .../media/platform/starfive/camss/Makefile    |   2 +
>>  .../media/platform/starfive/camss/stf_camss.c |  76 ++-
>>  .../media/platform/starfive/camss/stf_camss.h |   3 +
>>  .../media/platform/starfive/camss/stf_isp.c   | 519 ++++++++++++++++++
>>  .../media/platform/starfive/camss/stf_isp.h   | 479 ++++++++++++++++
>>  .../platform/starfive/camss/stf_isp_hw_ops.c  | 468 ++++++++++++++++
>>  6 files changed, 1544 insertions(+), 3 deletions(-)
>>  create mode 100644 drivers/media/platform/starfive/camss/stf_isp.c
>>  create mode 100644 drivers/media/platform/starfive/camss/stf_isp.h
>>  create mode 100644 drivers/media/platform/starfive/camss/stf_isp_hw_ops.c
> 
> Just a quick note:
> 
> When I compile this I get the following warnings:
> 
> drivers/media/platform/starfive/camss/stf_camss.c: In function 'stfcamss_subdev_notifier_bound':
> drivers/media/platform/starfive/camss/stf_camss.c:217:23: warning: 'pad[0]' may be used uninitialized [-Wmaybe-uninitialized]
>   217 |                 ret = v4l2_create_fwnode_links_to_pad(subdev, pad[i], 0);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/starfive/camss/stf_camss.c:202:27: note: 'pad[0]' was declared here
>   202 |         struct media_pad *pad[STF_PADS_NUM];
>       |                           ^~~
> drivers/media/platform/starfive/camss/stf_isp.c: In function 'isp_try_format.isra':
> drivers/media/platform/starfive/camss/stf_isp.c:105:40: warning: 'formats' may be used uninitialized [-Wmaybe-uninitialized]
>   105 |         const struct isp_format_table *formats;
>       |                                        ^~~~~~~
> drivers/media/platform/starfive/camss/stf_isp.c:105:40: note: 'formats' was declared here
>   105 |         const struct isp_format_table *formats;
>       |                                        ^~~~~~~
> drivers/media/platform/starfive/camss/stf_isp.c:106:30: warning: 'rect' may be used uninitialized [-Wmaybe-uninitialized]
>   106 |         struct stf_isp_crop *rect;
>       |                              ^~~~
> drivers/media/platform/starfive/camss/stf_isp.c:106:30: note: 'rect' was declared here
>   106 |         struct stf_isp_crop *rect;
>       |                              ^~~~
> 
> That's when I build with: make W=1 KCFLAGS=-Wmaybe-uninitialized
> 

OK, I will fix these warnings.

> Regards,
> 
> 	Hans
> 
>> 

-- 
Regards,

Jack Zhu