Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker

[Qi Zheng]

On 2023/7/26 15:04, Muchun Song wrote:
> > On Jul 24, 2023, at 17:43, Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx> wrote:
> >
> > Use new APIs to dynamically allocate the rcu-lazy shrinker.
> >
> > Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> > ---
> > kernel/rcu/tree_nocb.h | 19 +++++++++++--------
> > 1 file changed, 11 insertions(+), 8 deletions(-)
> >
> > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
> > index 43229d2b0c44..919f17561733 100644
> > --- a/kernel/rcu/tree_nocb.h
> > +++ b/kernel/rcu/tree_nocb.h
> > @@ -1397,12 +1397,7 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
> > return count ? count : SHRINK_STOP;
> > }
> >
> > -static struct shrinker lazy_rcu_shrinker = {
> > -	.count_objects = lazy_rcu_shrink_count,
> > -	.scan_objects = lazy_rcu_shrink_scan,
> > -	.batch = 0,
> > -	.seeks = DEFAULT_SEEKS,
> > -};
> > +static struct shrinker *lazy_rcu_shrinker;
>
> Seems there is no users of this variable, maybe we could drop
> this.

Yeah, will change it to a local variable. And the patch #15 is
the same.

>