Re: [PATCH v12 0/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066

From: Johan Hovold
Date: Wed Jul 26 2023 - 03:05:18 EST


On Wed, Jul 26, 2023 at 01:22:43PM +0800, Tim Jiang wrote:

Thanks for adding the changelog.

You should also add a sentence or two here that describes what the
series does (e.g. just say "This series adds support for ...").

Also make sure to run scripts/get_maintainer.pl on your series. Looks
like you're still missing some maintainers on CC.

You also did not CC at least on person providing review feedback on
earlier versions.

> Changes in v12
> - fix compile error issue for patch 1/2
>
> Changes in v11
> - reverse two patches order
>
> Changes in v10
> - break out btsoc type print into seperate patch
>
> Changes in v2-v9
> - solve review comments for code style and commit message context

This is not detailed enough for a changelog, but ok, let's forget about
v2-v9 this time, but remember it for your future submissions.

> Tim Jiang (2):
> Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
> Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066

As I mentioned elsewhere, these Subjects should be distinct and
summarise what each patch does.

Johan