RE: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd

[Peng Fan]

> Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
> 
> On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> 
> Why not just add a soc-specific compatible for the i.MX8DXL?
> The current form of this does not look right to me.

I could add one dedicated for i.MX8DXL.

Thanks,
Peng.

> 
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> >  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > index 407b7cfec783..3a92e4fef7ae 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > @@ -18,11 +18,14 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    items:
> > +    oneOf:
> >        - enum:
> > -          - fsl,imx8qm-scu-pd
> > -          - fsl,imx8qxp-scu-pd
> > -      - const: fsl,scu-pd
> > +          - fsl,scu-pd
> > +      - items:
> > +          - enum:
> > +              - fsl,imx8qm-scu-pd
> > +              - fsl,imx8qxp-scu-pd
> > +          - const: fsl,scu-pd
> >
> >    '#power-domain-cells':
> >      const: 1
> > --
> > 2.37.1
> >