Re: [PATCH v2] sparc: Use shared font data

[Dr. David Alan Gilbert]

* John Paul Adrian Glaubitz (glaubitz@xxxxxxxxxxxxxxxxxxx) wrote:
> Hi Dave!

Hi Adrian,

> On Tue, 2023-07-25 at 16:53 +0000, Dr. David Alan Gilbert wrote:
> > * Sam Ravnborg (sam@xxxxxxxxxxxx) wrote:
> > > On Tue, Jul 25, 2023 at 12:58:51AM +0100, linux@xxxxxxxxxxx wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > > 
> > > > sparc has a 'btext' font used for the console which is almost identical
> > > > to the shared font_sun8x16, so use it rather than duplicating the data.
> > > > 
> > > > They were actually identical until about a decade ago when
> > > >    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
> > > >                         "broken bar" to "vertical line"")
> > > > 
> > > > which changed the | in the shared font to be a solid
> > > > bar rather than a broken bar.  That's the only difference.
> > > > 
> > > > This was originally spotted by PMD which noticed that PPC does
> > > > the same thing with the same data, and they also share a bunch
> > > > of functions to manipulate the data.  The PPC code and the functions
> > > > I'll look at another time if this patch is OK.
> > > > 
> > > > Tested very lightly with a boot without FS in qemu.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > > 
> > > Looks good, thanks for the fixes.
> > > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > 
> > Thanks
> > 
> > > Let's hope someone picks it up...
> > 
> > I was hoping Dave would, but I realise Sparc doesn't get much
> > these days.
> > Of course if anyone feels guilty about their own patches adding code
> > they can take this patch to make ~340 lines of penance.
> 
> You can ask Andrew Morton to pick it up through his tree. He usually does
> that when no one else is willing to pick a patch up.

  Thanks for the suggestion, I've copied Andrew in, although
there's obviously no rush since it's just a dedupe.

Dave

> Adrian
> 
> -- 
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer
> `. `'   Physicist
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/