Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema

From: Conor Dooley
Date: Tue Jul 25 2023 - 15:31:00 EST


On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> > The defaults are specified in the description instead of being specified
> > in the schema.
> > Fix it by adding the default value in the `default` field.
> >
> > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> > Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> > ---
>
> Maybe also fix the allowed range while at it? I.e.
>
> minimum: 0x00
> maximum: 0x7F

Beat me to it! Please do.

Attachment: signature.asc
Description: PGP signature