Re: [PATCH] regulator: dt-bindings: qcom,rpm: fix pattern for children

[Conor Dooley]

On Tue, Jul 25, 2023 at 06:40:47PM +0200, Krzysztof Kozlowski wrote:
> The "or" (|) in regular expression must be within parentheses,
> otherwise it is not really an "or" and it matches supplies:
> 
>   qcom-apq8060-dragonboard.dtb: regulators-1: vdd_ncp-supply: [[34]] is not of type 'object'
> 
> Fixes: fde0e25b71a9 ("dt-bindings: regulators: convert non-smd RPM Regulators bindings to dt-schema")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> ---
>  .../devicetree/bindings/regulator/qcom,rpm-regulator.yaml       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpm-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpm-regulator.yaml
> index 8a08698e3484..b4eb4001eb3d 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpm-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpm-regulator.yaml
> @@ -49,7 +49,7 @@ patternProperties:
>    ".*-supply$":
>      description: Input supply phandle(s) for this node
>  
> -  "^((s|l|lvs)[0-9]*)|(s[1-2][a-b])|(ncp)|(mvs)|(usb-switch)|(hdmi-switch)$":
> +  "^((s|l|lvs)[0-9]*|s[1-2][a-b]|ncp|mvs|usb-switch|hdmi-switch)$":
>      description: List of regulators and its properties
>      $ref: regulator.yaml#
>      unevaluatedProperties: false
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature