RE: pwm-rz-mtu3.c:undefined reference to `clk_rate_exclusive_put'

[Biju Das]

Hi Thierry Reding,

Thanks for the feedback.

> -----Original Message-----
> From: Thierry Reding <thierry.reding@xxxxxxxxx>
> Sent: Tuesday, July 25, 2023 5:21 PM
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: kernel test robot <lkp@xxxxxxxxx>; oe-kbuild-all@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Uwe Kleine-König <u.kleine-
> koenig@xxxxxxxxxxxxxx>
> Subject: Re: pwm-rz-mtu3.c:undefined reference to
> `clk_rate_exclusive_put'
> 
> On Tue, Jul 25, 2023 at 01:51:38PM +0000, Biju Das wrote:
> > Hi kernel test robot,
> >
> > I have fixed the original issue by adding dependency to COMMON_CLK.
> >
> > But I hit below error which related to m68k compiler/arch specific.
> > Can you please fix this issue?
> >
> > /home/user/0day/gcc-12.3.0-nolibc/m68k-linux/bin/m68k-linux-ld:
> > section .rodata VMA [00002000,009a758f] overlaps section .text VMA
> > [00000400,012a08ff]
> > make[2]: *** [../scripts/Makefile.vmlinux:35: vmlinux] Error 1
> > make[2]: Target '__default' not remade because of errors.
> > make[1]: *** [/builds/0/rzg2l-linux/Makefile:1250: vmlinux] Error 2
> > make[1]: Target '__all' not remade because of errors.
> > make[1]: Leaving directory '/builds/0/rzg2l-linux/build_dir'
> > make: *** [Makefile:226: __sub-make] Error 2
> > make: Target '__all' not remade because of errors.
> >
> > Note:
> > You can reproduce this issue by
> >
> > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index
> > 6210babb0741..eeecf249f372 100644
> > --- a/drivers/pwm/Kconfig
> > +++ b/drivers/pwm/Kconfig
> > @@ -506,6 +506,7 @@ config PWM_ROCKCHIP  config PWM_RZ_MTU3
> >         tristate "Renesas RZ/G2L MTU3a PWM Timer support"
> >         depends on RZ_MTU3 || COMPILE_TEST
> > +       depends on COMMON_CLK
> 
> It probably doesn't change anything about the build issue, but I think a
> slightly more correct dependency would be:
> 
> 	depends on HAVE_CLK

Nope. I used that one and still got build error. See[2]

[2] https://elixir.bootlin.com/linux/v6.5-rc3/source/drivers/clk/Makefile#L4

Cheers,
Biju

> 
> Thierry