Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability

From: Greg KH
Date: Tue Jul 25 2023 - 11:09:38 EST


On Tue, Jul 25, 2023 at 10:37:11AM -0400, Frank Li wrote:
> On Fri, Jul 07, 2023 at 07:00:14PM -0400, Frank Li wrote:
> > The legacy gadget driver omitted calling usb_gadget_check_config()
> > to ensure that the USB device controller (UDC) has adequate resources,
> > including sufficient endpoint numbers and types, to support the given
> > configuration.
> >
> > Previously, usb_add_config() was solely invoked by the legacy gadget
> > driver. Adds the necessary usb_gadget_check_config() after the bind()
> > operation to fix the issue.
> >
> > Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
> > Reported-by: Ravi Gunasekaran <r-gunasekaran@xxxxxx>
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
>
> @greg
> ping

It's in my review queue, please give me a chance to catch up.

While you wait, doing review of other USB patches would be most
appreciated.

thanks,

greg k-h