Re: [PATCH v2] platform/x86/intel/hid: Add HP Dragonfly G2 to VGBS DMI quirks

[Hans de Goede]

Hi,

On 7/16/23 20:32, Maxim Mikityanskiy wrote:
> HP Elite Dragonfly G2 (a convertible laptop/tablet) has a reliable VGBS
> method. If VGBS is not called on boot, the firmware sends an initial
> 0xcd event shortly after calling the BTNL method, but only if the device
> is booted in the laptop mode. However, if the device is booted in the
> tablet mode and VGBS is not called, there is no initial 0xcc event, and
> the input device for SW_TABLET_MODE is not registered up until the user
> turns the device into the laptop mode.
> 
> Call VGBS on boot on this device to get the initial state of
> SW_TABLET_MODE in a reliable way.
> 
> Tested with BIOS 1.13.1.
> 
> Signed-off-by: Maxim Mikityanskiy <maxtram95@xxxxxxxxx>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> ---
>  drivers/platform/x86/intel/hid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 5632bd3c534a..afa16520b363 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -150,6 +150,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "HP Elite Dragonfly G2 Notebook PC"),
> +		},
> +	},
>  	{ }
>  };
>