Re: [PATCH v2 1/1] Documentation: core-api: Drop :export: for int_log.h

From: Jonathan Corbet
Date: Tue Jul 25 2023 - 09:12:32 EST


Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:

> The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL()
> might appear. Otherwise kernel-doc may not produce anything out of this
> file.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Fixes: f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Acked-by: Jonathan Corbet <corbet@xxxxxxx>
> ---
> v2: added tags (Randy, Jonathan), assumed to go via ASoC tree
> Documentation/core-api/kernel-api.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index a526fbe06f86..ae92a2571388 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -166,7 +166,6 @@ Integer log and power Functions
> -------------------------------
>
> .. kernel-doc:: include/linux/int_log.h
> - :export:
>

So I still can't take this patch for the reasons described before. It
looks like Mark took the patch that added the problem, so perhaps he
should be a recipient of this one too? I'll add him to the CC...

jon