Re: [PATCH v9 03/10] usb: dwc3: core: Access XHCI address space temporarily to read port info

[Krishna Kurapati PSSNV]

On 7/24/2023 9:11 PM, Johan Hovold wrote:
> [ Please remember to trim your replies. ]
>
> On Sun, Jul 23, 2023 at 08:29:47PM +0530, Krishna Kurapati PSSNV wrote:
> > On 6/27/2023 5:15 PM, Johan Hovold wrote:
> > > On Wed, Jun 21, 2023 at 10:06:21AM +0530, Krishna Kurapati wrote:
>
> > > > +#define XHCI_EXT_PORT_MAJOR(x)	(((x) >> 24) & 0xff)
> > > > +#define XHCI_EXT_PORT_MINOR(x)	(((x) >> 16) & 0xff)
> > > > +#define XHCI_EXT_PORT_COUNT(x)	(((x) >> 8) & 0xff)
> > >
> > > Again, don't copy defines from xhci.
> > >
> > > Looks like these should be moved to the xhci-ext-caps.h header along
> > > with struct xhci_protocol_caps.
> >
> > Moving the defines would be sufficient right ? Just wanted to know if
> > there is any reason you are suggesting to move the structure as well so
> > that I can update commit text accordingly.
>
> The defines are used for parsing the members of struct
> xhci_protocol_caps and they belong together even if no driver has
> apparently ever used the structure.
Hi Johan,

Thanks for the suggestions. Will push out v10 today.

Regards,
Krishna,