Re: [PATCH v2] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64

[Lin Ma]

Hello Jakub,

> > The nla_for_each_nested parsing in function mqprio_parse_nlattr() does
> > not check the length of the nested attribute. This can lead to an
> > out-of-attribute read and allow a malformed nlattr (e.g., length 0) to
> > be viewed as 8 byte integer and passed to priv->max_rate/min_rate.
> > 
> > This patch adds the check based on nla_len() when check the nla_type(),
> > which ensures that the length of these two attribute must equals
> > sizeof(u64).
> 
> How do you run get_maintainer? You didn't CC the author of the code.

That's weird, I just ran code below and send this patch to all 9 emails poped out.

# ./scripts/get_maintainer.pl net/sched/sch_mqprio.c
Jamal Hadi Salim <jhs@xxxxxxxxxxxx> (maintainer:TC subsystem)
Cong Wang <xiyou.wangcong@xxxxxxxxx> (maintainer:TC subsystem)
Jiri Pirko <jiri@xxxxxxxxxxx> (maintainer:TC subsystem)
"David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING [GENERAL])
Eric Dumazet <edumazet@xxxxxxxxxx> (maintainer:NETWORKING [GENERAL])
Jakub Kicinski <kuba@xxxxxxxxxx> (maintainer:NETWORKING [GENERAL])
Paolo Abeni <pabeni@xxxxxxxxxx> (maintainer:NETWORKING [GENERAL])
netdev@xxxxxxxxxxxxxxx (open list:TC subsystem)
linux-kernel@xxxxxxxxxxxxxxx (open list)

Can you tell me which one is missing and I will resend the patch to him.

Thanks
Lin