Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector

[Rob Herring]

On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
> The usb-connector.yaml schema allows any additional properties, thus its
> usage should finish with unevaluatedProperties: false.

Is it problematic if usb-connector.yaml is restricted?

> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/maxim,max33359.yaml       | 1 +
>  Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 1 +
>  Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml        | 1 +
>  Documentation/devicetree/bindings/usb/mediatek,musb.yaml        | 1 +
>  Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml      | 1 +
>  Documentation/devicetree/bindings/usb/richtek,rt1719.yaml       | 1 +
>  6 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> index 276bf7554215..45e093978b82 100644
> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> @@ -25,6 +25,7 @@ properties:
>    connector:
>      type: object
>      $ref: ../connector/usb-connector.yaml#
> +    unevaluatedProperties: false
>      description:
>        Properties for usb c connector.
>  
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..42b9d3a35c67 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -29,6 +29,7 @@ properties:
>    connector:
>      type: object
>      $ref: ../connector/usb-connector.yaml#
> +    unevaluatedProperties: false
>      description:
>        Properties for usb c connector.
>  
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index a59d91243ac8..7eb880e4a270 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -144,6 +144,7 @@ properties:
>  
>    connector:
>      $ref: /schemas/connector/usb-connector.yaml#
> +    unevaluatedProperties: false
>      description:
>        Connector for dual role switch, especially for "gpio-usb-b-connector"
>      type: object
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> index a39d38db7714..924f74d45baa 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> @@ -66,6 +66,7 @@ properties:
>      $ref: /schemas/connector/usb-connector.yaml#
>      description: Connector for dual role switch
>      type: object
> +    unevaluatedProperties: false
>  
>  dependencies:
>    usb-role-switch: [ connector ]
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> index 8da4d2ad1a91..980235e27a7f 100644
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> @@ -36,6 +36,7 @@ properties:
>    connector:
>      type: object
>      $ref: /schemas/connector/usb-connector.yaml#
> +    unevaluatedProperties: false
>      description:
>        Properties for usb c connector.
>  
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> index 4ced2f68e2a9..27978580b234 100644
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> @@ -34,6 +34,7 @@ properties:
>    connector:
>      type: object
>      $ref: ../connector/usb-connector.yaml#
> +    unevaluatedProperties: false
>      description:
>        Properties for usb c connector.
>  
> -- 
> 2.34.1
>