Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes

From: Francesco Dolcini
Date: Mon Jul 24 2023 - 12:23:07 EST


Hello Judith,

On Mon, Jul 24, 2023 at 11:06:24AM -0500, Judith Mendez wrote:
> On 7/24/23 8:36 AM, Francesco Dolcini wrote:
> > From: Judith Mendez <jm@xxxxxx>
> >
> > On AM62x there are no hardware interrupts routed to A53 GIC
> > interrupt controller for MCU MCAN IPs, so MCU MCAN nodes were
> > omitted from MCU dtsi.
> >
> > Timer polling was introduced in commits [1][2] so now add MCU MCAN nodes
> > to the MCU dtsi for the Cortex A53.
> >
> > [1] b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
> > [2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN")
> >
> > Signed-off-by: Judith Mendez <jm@xxxxxx>
> > [fd: fixed labels to match datasheet numbering, revised commit message,
> > fixed reg/reg-names order]
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > ---

...

> Thanks for sending this patch, will also send for AM62ax.

Please have a look at the couple of changes I did:
- corrected the label to be coherent with the datasheet and the other
peripheral names
- inverted "m_can" and "message_ram" regs/regs-names to fix a binding
checker error.

These might be relevant also for the AM62a.

Francesco