Re: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

[Florian Fainelli]

On 7/20/2023 5:40 PM, Tristram.Ha@xxxxxxxxxxxxx wrote:
> From: Tristram Ha <Tristram.Ha@xxxxxxxxxxxxx>
>
> Microchip LAN8740/LAN8742 PHYs support basic unicast, broadcast, and
> Magic Packet WoL.  They have one pattern filter matching up to 128 bytes
> of frame data, which can be used to implement ARP or multicast WoL.
>
> ARP WoL matches any ARP frame with broadcast address.
>
> Multicast WoL matches any multicast frame.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@xxxxxxxxxxxxx>

This looks good to me, just one suggestion but which you can implement 
later, it would be nice to have a pm_wakeup_event(&phydev->mdio.dev, 0) 
in order to have the PHY device accounted for any wake-up event. You can 
do that when you do the initial acknowledgement of any wake-up 
interrupts in your .config_init callback.

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian