Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'

From: Kamalesh Babulal
Date: Mon Jul 24 2023 - 09:47:36 EST




On 7/24/23 17:24, Kai Huang wrote:
> The comment of the 'failed' member of 'struct misc_res' is obsolete
> since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> flood"), which removed the 'failed' member from the structure. Remove
> the obsolete comment.
>
> Also add the missing comment for the 'events' field, which should come
> with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> failures") where the 'events' member was added.

This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@xxxxxxxxxx/

>
> Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>
> ---
> include/linux/misc_cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c238207d1615..41aa213a1125 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -31,7 +31,7 @@ struct misc_cg;
> * struct misc_res: Per cgroup per misc type resource
> * @max: Maximum limit on the resource.
> * @usage: Current usage of the resource.
> - * @failed: True if charged failed for the resource in a cgroup.
> + * @events: Charge failure event counter of the resource.
> */
> struct misc_res {
> unsigned long max;
>
> base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c

--
Thanks,
Kamalesh