Re: [PATCH v3] cdx: add support for bus mastering

From: Greg KH
Date: Mon Jul 24 2023 - 08:28:49 EST


On Mon, Jul 24, 2023 at 05:34:33PM +0530, Nipun Gupta wrote:
> Introduce cdx_set_master() and cdx_clear_master() APIs to support
> enable and disable of bus mastering. Drivers need to use these APIs to
> enable/disable DMAs from the CDX devices.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@xxxxxxx>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>
> ---

You are adding apis here that no one is actually using, making it pretty
impossible to see if they are being used properly, or if they are even
needed at all.

Please submit this as part of a patch series that uses the apis,
otherwise there's no need for anyone to accept this patch.

thanks,

greg k-h