Re: WARNING: CPU: 1 PID: 67 at drivers/ata/libata-core.c:1688 ata_read_log_page+0x173/0x1f0

From: Borislav Petkov
Date: Mon Jul 24 2023 - 07:53:49 EST


+ hare.

On Mon, Jul 24, 2023 at 01:51:19PM +0200, Niklas Cassel wrote:
> Hello Boris,
>
> this is a null pointer dereference,
> because ap->ncq_sense_buf buffer is only allocated when CDL is enabled.
>
> We are not supposed to fetch sense data for successful NCQ commands when
> CDL is not enabled.
>
> This is my bad.
> Could you please test and see if this patch solves your problem:
> https://lore.kernel.org/linux-ide/20230723130315.427513-1-nks@xxxxxxxxxxx/

Yap, saw it, thanks.

I'll be able to get to it towards the end of the week.

Will let you know,

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette