Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC

[Alina Yu]

Hi,
Krzysztof:

> > > ...
> > > 
> > >>> +
> > >>> +          regulator-mode:
> > >>> +            enum: [0, 1]
> > >>> +            description:
> > >>> +              describe buck initial operating mode in suspend state.
> > >>
> > >> There is no such property on this level. Aren't you mixing initial one?
> > > 
> > > It's the initial mode in suspend-mem state, should I modify that like this ?
> > >         patternProperties:
> > >           "^regulator-state-(standby|mem|disk)$":
> > > 	    type: object
> > > 	    $ref: regulator.yaml#
> > > 	    properties:
> > > 	      regulator-mode:
> > > 	        enum: [0, 1]
> > > 		description:
> > >                   describe byck initial operating mode in suspend state.
> > 
> > Please check how other bindings do it.
> >
> 
> If I modify that like this, will it be correct ?
> 
> 
> ...
>           regulator-state-mem:
> 	    type: object
> 	    $ref: regulator.yaml#
> 	    properties:
> 	      regulator-mode:
> 	      description:
> 	        describe buck initial operating mode in suspend state.
> 		0 - Auto mode
> 		1 - FCCM
>

Sorry, I think I didn't explain well why to add "regulator-mode".
I just want to add description for this property, for people can get its meaning when they see the yaml.
If it's optional and it's already a general property in regulator.yaml.
May I remove it from my yaml ?

Best regards,
Alina