Re: [PATCH v4] wifi: ath9k: fix printk specifier

From: Toke Høiland-Jørgensen
Date: Sun Jul 23 2023 - 18:10:57 EST


Dongliang Mu <dzm91@xxxxxxxxxxx> writes:

> Smatch reports:
>
> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
>
> Fix it by modifying %lx to %p in the printk format string.
>
> Note that with this change, the pointer address will be printed as a
> hashed value by default. This is appropriate because the kernel
> should not leak kernel pointers to user space in an informational
> message. If someone wants to see the real address for debugging
> purposes, this can be achieved with the no_hash_pointers kernel option.
>
> Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx>

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>