Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

[Krzysztof Kozlowski]

On 21/07/2023 14:25, Viktar Simanenka wrote:
> On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 20/07/2023 14:40, Viktar Simanenka wrote:
>>> +allOf:
>>> +  - $ref: panel/panel-common.yaml#
>>
>> This is not a panel, is it?
> 
> I can't clearly tell the difference between LCD display and panel.
> I've added panel-common because of 'backlight' and 'reset-gpios'
> properties. I've looked at 'sitronix,st7735r.yaml',
> 'ilitek,ili9486.yaml' as examples. SPI controlled LCD displays, but in

Probably your device is not a panel (datasheet says: LCD controller),
thus it should not reference panel-common.


> color.
> In fact 'reset-gpios' is already in my yaml. I might just add the
> 'backlight' property explicitly and remove this dependency. Should I?

Best regards,
Krzysztof