RE: [PATCH] mei: pxp: Keep a const qualifier when calling mei_cldev_send()

From: Winkler, Tomas
Date: Sat Jul 22 2023 - 07:36:46 EST


> The API has been fixed in commit 0912ef4855e8 ("mei: constify passed
> buffers and structures"), so there is no more need to drop the const qualifier
> and the comment can be removed as-well.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Acked-by Tomas Winkler <tomas.winkler@xxxxxxxxx>

> ---
> drivers/misc/mei/pxp/mei_pxp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/pxp/mei_pxp.c
> b/drivers/misc/mei/pxp/mei_pxp.c index 3bf560bbdee0..2dcb9169e404
> 100644
> --- a/drivers/misc/mei/pxp/mei_pxp.c
> +++ b/drivers/misc/mei/pxp/mei_pxp.c
> @@ -40,8 +40,7 @@ mei_pxp_send_message(struct device *dev, const void
> *message, size_t size)
>
> cldev = to_mei_cl_device(dev);
>
> - /* temporary drop const qualifier till the API is fixed */
> - byte = mei_cldev_send(cldev, (u8 *)message, size);
> + byte = mei_cldev_send(cldev, message, size);
> if (byte < 0) {
> dev_dbg(dev, "mei_cldev_send failed. %zd\n", byte);
> return byte;
> --
> 2.34.1